Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirejs should be loaded in the header with plotly #275

Merged
merged 1 commit into from
Jul 1, 2019
Merged

requirejs should be loaded in the header with plotly #275

merged 1 commit into from
Jul 1, 2019

Conversation

alexisduque
Copy link
Contributor

this fix #141

@SylvainCorlay
Copy link
Member

Thanks!

@SylvainCorlay SylvainCorlay merged commit eeaff34 into voila-dashboards:master Jul 1, 2019
@maartenbreddels
Copy link
Member

Do you have an explanation for why this works?

@alexisduque
Copy link
Contributor Author

@maartenbreddels as explained in #141 plotly tries to use require.js before it gets imported since it is loaded in the footer in the template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require.js is loaded after plotly needs it
3 participants
@alexisduque @SylvainCorlay @maartenbreddels